Hi, With The Upcoming Version Of Hydra It Seems The Binding Breaks. Specifically In The

Answered

Hi, with the upcoming version of Hydra it seems the binding breaks. Specifically in the run_job function the argument order changed from https://github.com/facebookresearch/hydra/blob/677c99a19be8dfa38d2c19e3b722f1e7a2fed8bf/hydra/core/utils.py#L82 to https://github.com/facebookresearch/hydra/blob/8be4c62aeacfe7d03cdfb60b55d85e42feac6ec1/hydra/core/utils.py#L110 . Which breaks line 121 of hydra_bind.py :
result = PatchHydra._original_run_job( config, partial(PatchHydra._patched_task_function, task_function,), *args, **kwargs)This could be solved by passing the arguments name. How can I help with this?

  				
Posted 
	3 years ago

					More
				  		
  Report
		
					GrievingTurkey78
				
					0
					 × 1

Votes Newest

Answers 5

Yey!

  				
Posted 
	3 years ago

					More
				  		
  Report
		
					AgitatedDove14
				
					0
					 × 1

I’ll open the PR!

  				
Posted 
	3 years ago

					More
				  		
  Report
		
					GrievingTurkey78
				
					0
					 × 1

Ohh sorry you will also need to fix the

def _patched_task_function

The parameter order is important as the partial call relies on it.

My bad no need for that 🙂

  				
Posted 
	3 years ago

					More
				  		
  Report
		
					AgitatedDove14
				
					0
					 × 1

Ohh sorry you will also need to fix the def _patched_task_function
The parameter order is important as the partial call relies on it.

  				
Posted 
	3 years ago

					More
				  		
  Report
		
					AgitatedDove14
				
					0
					 × 1

Thanks GrievingTurkey78
Sure just PR (should work with any Python/Hydra version):
kwargs['config']=config kwargs['task_function']=partial(PatchHydra._patched_task_function, task_function,) result = PatchHydra._original_run_job(*args, **kwargs)

  				
Posted 
	3 years ago

					More
				  		
  Report
		
					AgitatedDove14
				
					0
					 × 1

Write your answer

934 Views

5 Answers

3 years ago

one year ago