No worries, you open the issue on pypa/pip and I will do my best to push forward 🙂
We also have to be realistic I have a PR that is waiting for almost a year now (that said it is a major one and needed to wait until a few more features were merged), basically what I'm saying best case scenario is a month to get a PR merged
error in my-package setup command:
Okay this seems like an error in the setup.py you have in the "mypackage" folder
and when you remove the "." line does it work?
yes, because it won’t install the local package which has this setup.py with the problem in its install_requires described in my previous message
JitteryCoyote63 see here https://stackoverflow.com/questions/55385900/pip3-setup-py-install-requires-pep-508-git-url-for-private-repo bottom line, you have to add package@ before the link, but if you do that and the package is already installed it will not install using the git repo, this is an issue with pip. I think that since the agent installs everything from scratch it should work for you. Wdyt?
That would be awesome, yes, only from my side I have 0 knowledge of the pip codebase 😄
yes, the only thing I changed is:install_requires=[ ... "my-dep @ git+ ]to:install_requires=[ ... "git+ "]
With env caching enabled, it won’t reinstall this private dependency, right?
It will, local packages (".") and git packages are alwyas reinstalled even if using venv caching, exactly for that reason 🙂
Sorry, its actuallytask.update_requirements(["."])
Ohh so the setup.py is the one containing these requirements, oops I totally missed that :( let me check what pep has to say about that ... (Basically this is not a clearml issue but a pip one...)
Exactly, that’s my problem: I want to remove it to make sure it is reinstalled (because the version can change)
JitteryCoyote63 yes, this is definitely a pip bug... can you test with the latest pip version, maybe it was fixed? (i.e. git+https:// link)
but if you do that and the package is already installed it will not install using the git repo, this is an issue with pip
Exactly, that’s my problem: I want to remove it to make sure it is reinstalled (because the version can change)
I think that since the agent installs everything from scratch it should work for you. Wdyt?
With env caching enabled, it won’t reinstall this private dependency, right?
If we have the time maybe we could PR a fix?!
Could you post what you see under "installed packages" in the UI ?
JitteryCoyote63 you mean? (notice no brackets)task.update_requirements(".") Either pass a text or a list of lines:
The safest would be '\n'.join(all_req_lines)
oh dear 😞 if that's the case I think you should open an Issue on pypa/pip , I'm not sure what we can do other than that ...
I am already trying with latest of pip 😞
Try:task.update_requirements('\n'.join([".", ]))