Thanks everyone!

Hi everyone, I just fixed releases so new charts containing this fix are published. ty!

Thanks! PR merged 🚀

https://github.com/allegroai/clearml-helm-charts/pull/107

https://github.com/allegroai/clearml-helm-charts/blob/0871e7383130411694482468c228c987b0f47753/charts/clearml-agent/templates/agentk8sglue-deployment.yaml#L47

For instance, quotes are used

I think the quotes don't effect the yaml

I can open a PR

Yes please 🙂
BTW: I originally thought the double quotes (in your PR) were also a bug, this is why I was asking, wdyt?

Do you want me to PR that fix?

Yea that is a similar bug, needs the same fix

Yes! Thanks so much for the quick turnaround

My pleasure 🙂

BTW: did you see this (it seems like the same bug?!)
https://github.com/allegroai/clearml-helm-charts/blob/0871e7383130411694482468c228c987b0f47753/charts/clearml-agent/templates/agentk8sglue-configmap.yaml#L14

Yes! Thanks so much for the quick turnaround

Merged, is it working for you now?

I made the PR here JuicyFox94 AgitatedDove14 https://github.com/allegroai/clearml-helm-charts/pull/106

I cannot test it at the moment, hence my question.
JuicyFox94 any chance you can blindly approve ?

Its clearly a bug

You guys are the maintainers of this repo

I dont know how to do that

Test it on your local setup (I would hate to push a broken fix)
Is that possible?

Seems like its just missing the brackets

I learned helm a few days ago

I'm not familiar with helm that well to clone this, fix it, and then test

(once you verify PR the fix, I'll make sure it is merged)

Can you fix locally, just to verify ?

Can you fix this or should I open a PR. I'm blocked by this.

ouch, I think you are correct, can you test a fix?

AgitatedDove14 note the missing brackets https://github.com/allegroai/clearml-helm-charts/blob/main/charts/clearml-agent/templates/agentk8sglue-deployment.yaml#L22

Shouldn't this be a real value and not a template

you mean value being pulled to the pod that failed ?

Yea this is a bug