Examples: query, "exact match", wildcard*, wild?ard, wild*rd
Fuzzy search: cake~ (finds cakes, bake)
Term boost: "red velvet"^4, chocolate^2
Field grouping: tags:(+work -"fun-stuff")
Escaping: Escape characters +-&|!(){}[]^"~*?:\ with \, e.g. \+
Range search: properties.timestamp:[1587729413488 TO *] (inclusive), properties.title:{A TO Z}(excluding A and Z)
Combinations: chocolate AND vanilla, chocolate OR vanilla, (chocolate OR vanilla) NOT "vanilla pudding"
Field search: properties.title:"The Title" AND text
Answered
I Just Posted A Gh Issue Which Totally Prevents Me From Using A Scheduler.

I just posted a GH issue which totally prevents me from using a scheduler. https://github.com/allegroai/clearml/issues/648 Maybe I missed something, but it looks like quite a major problem

  
  
Posted 2 years ago
Votes Newest

Answers 16


I already added to the task:
Workaround: Remove limit_execution_time from scheduler.add_task

  
  
Posted 2 years ago

I can try, but difficult to verify correctness without a publicly available test suite

  
  
Posted 2 years ago

FiercePenguin76 , maybe add it as PR 🙂

  
  
Posted 2 years ago

I thought that I can keep self._timeout_jobs = {} # Dict[datetime, str] intact and fix the part where we need to extract keys instead of values.

  
  
Posted 2 years ago

But the second problem hints that we need to change Dict[datetime, str] -> Dict[str, datetime] or do some custom processing before serialization

  
  
Posted 2 years ago

Thanks FiercePenguin76 , I can totally understand your point on running proper tests, and reluctance to break other things.
I suggest to add a comment with the temp fix that solved the problem for you, and we will make sure the team takes it from there. wdyt?

  
  
Posted 2 years ago

I’ll make it more visible though

  
  
Posted 2 years ago

Many thanks! 😍

  
  
Posted 2 years ago

Also added implementation thought to the issue

  
  
Posted 2 years ago

The only thing I found is that I need to run flake8, but it fails even without any changes, i.e. it was not enforced before (see my msg in )

  
  
Posted 2 years ago

I think I’ll skip with PR: there is a related problem, that makes the fix (and especially its testing much more difficult): https://github.com/allegroai/clearml/issues/648#issuecomment-1102595620

  
  
Posted 2 years ago

Did a small update: added a workaround and renamed the issue to include more client_facing condition
limit_execution_time is presentinstead of an implementation detail condition
timeout_jobs are present

  
  
Posted 2 years ago

difficult to verify correctness without a publicly available test suite

What'd you mean?

  
  
Posted 2 years ago

and this can break a lot of things, when somebody start the scheduler with an older version of clearml, saves the state, then upgrades and new clearml expects the state in another format

  
  
Posted 2 years ago

if a provide a PR, there I don’t see any CI processes in place that will verify the correctness of my code.

  
  
Posted 2 years ago

For me - workaround is totally acceptable, thus scheduler is once again usable for me.

  
  
Posted 2 years ago
687 Views
16 Answers
2 years ago
one year ago
Tags