Examples: query, "exact match", wildcard*, wild?ard, wild*rd
Fuzzy search: cake~ (finds cakes, bake)
Term boost: "red velvet"^4, chocolate^2
Field grouping: tags:(+work -"fun-stuff")
Escaping: Escape characters +-&|!(){}[]^"~*?:\ with \, e.g. \+
Range search: properties.timestamp:[1587729413488 TO *] (inclusive), properties.title:{A TO Z}(excluding A and Z)
Combinations: chocolate AND vanilla, chocolate OR vanilla, (chocolate OR vanilla) NOT "vanilla pudding"
Field search: properties.title:"The Title" AND text
Answered
I Just Posted A Gh Issue Which Totally Prevents Me From Using A Scheduler.

I just posted a GH issue which totally prevents me from using a scheduler. https://github.com/allegroai/clearml/issues/648 Maybe I missed something, but it looks like quite a major problem

  
  
Posted one year ago
Votes Newest

Answers 16


Did a small update: added a workaround and renamed the issue to include more client_facing condition
limit_execution_time is presentinstead of an implementation detail condition
timeout_jobs are present

  
  
Posted one year ago

Many thanks! 😍

  
  
Posted one year ago

For me - workaround is totally acceptable, thus scheduler is once again usable for me.

  
  
Posted one year ago

FiercePenguin76 , maybe add it as PR 🙂

  
  
Posted one year ago

I thought that I can keep self._timeout_jobs = {} # Dict[datetime, str] intact and fix the part where we need to extract keys instead of values.

  
  
Posted one year ago

if a provide a PR, there I don’t see any CI processes in place that will verify the correctness of my code.

  
  
Posted one year ago

and this can break a lot of things, when somebody start the scheduler with an older version of clearml, saves the state, then upgrades and new clearml expects the state in another format

  
  
Posted one year ago

Also added implementation thought to the issue

  
  
Posted one year ago

Thanks FiercePenguin76 , I can totally understand your point on running proper tests, and reluctance to break other things.
I suggest to add a comment with the temp fix that solved the problem for you, and we will make sure the team takes it from there. wdyt?

  
  
Posted one year ago

I think I’ll skip with PR: there is a related problem, that makes the fix (and especially its testing much more difficult): https://github.com/allegroai/clearml/issues/648#issuecomment-1102595620

  
  
Posted one year ago

The only thing I found is that I need to run flake8, but it fails even without any changes, i.e. it was not enforced before (see my msg in )

  
  
Posted one year ago

But the second problem hints that we need to change Dict[datetime, str] -> Dict[str, datetime] or do some custom processing before serialization

  
  
Posted one year ago

difficult to verify correctness without a publicly available test suite

What'd you mean?

  
  
Posted one year ago

I already added to the task:
Workaround: Remove limit_execution_time from scheduler.add_task

  
  
Posted one year ago

I can try, but difficult to verify correctness without a publicly available test suite

  
  
Posted one year ago

I’ll make it more visible though

  
  
Posted one year ago
368 Views
16 Answers
one year ago
10 months ago
Tags