Here's an example where poetry.lock
is removed, and still the console reads:url:
.... branch: HEAD commit: 22fffaf8d5f377b7f10140e642a7f6f26b72ffaa root: /.../.clearml/venvs-builds/3.10/task_repository/... Applying uncommitted changes Poetry Enabled: Ignoring requested python packages, using repository poetry lock file! Creating virtualenv ds-platform in /.../.clearml/venvs-builds/3.10/task_repository/.../.venv Updating dependencies Resolving dependencies...
Wait who is creating this file? I thought you remove it in the uncommitted changes
Uhhh, but pyproject.toml does not necessarily entail poetry... It's a new Python standard
remote repository
's lock file.
Which file is that? the poetry lock of the internal VCS lock (the agent itself)
@<1523701083040387072:profile|UnevenDolphin73> it's looking for any of the files:
None
I understand, but then the toml file needs to be parsed to ensure poetry is used. It's just a tool entry in the pyproject.toml.
Hmm @<1523701083040387072:profile|UnevenDolphin73> I think this is the reason, None
and this means that even without a full lock file poetry can still build an environment
Couldn't the agent just come with the toml library? Kinda easy to load up and check if poetry is present then... 🤔
But yes it indeed used poetry correctly, though it would fail in other circumstances
I think poetry should somehow return error if toml is "empty" then we can detect it...
I understand, but then the toml file needs to be parsed to ensure poetry is used. It's just a tool entry in the pyproject.toml.
Probably too much for the agent... and specifically it seems poetry actually managed to parse it?! what are you getting in the log?
Hi UnevenDolphin73
If you "remove" the lock file the agent will default to pip.
You can hack it with uncommitted changes section?
Sorry AgitatedDove14 , forgot to get back to this.
I've been trying to convince my team to drop poetry 😄
The poetry.lock
in github, it seems 🤔
It's pulled from the remote repository, my best guess is that the uncommitted changes apply only after the environment is set up?
No after, do you see the poetry lock removed in the uncommitted changes?
It seems that the agent uses the remote repository 's lock file. We've removed and renamed the file locally (caught under local changes), but it still installs from the remote lock file 🤔